Custom commands ignore nick -- please help!

[fabian]

If you check out the command customization example in the faq:

http://www.phpfreechat.net/src/1.x/demo ... ommand.php


Try entering this chat, change your nick, (e.g. /nick NewGuest),
and then enter the custom command (e.g. /roll 1d6).

Note that the chat lists a random new nick as now having sent that command, rather than you.

This is a bug, surely? Can anyone help me to fix this, please?


Thank you


Fabian


PS. Great chat otherwise, I really love it!

[fabian]

Hello? Anyone? Could anyone at least try this and tell me whether they have the same problem? Please? Or is there a simple trick to get this going and display the correct nickname? Does anyone know?

[OldWolf]

Bug confirmed.

[fabian]

Thank you.

[fabian]

I fixed this bug now: The appropriate code in the custom class has a general error that does not correctly report the nick; I presume this was older version code. The code in the custom class example should instead, for the main page, read initially:

Code: Select all

function run(&$xml_reponse, $p)
  {
    $clientid    = $p["clientid"];
    $param       = $p["param"];
    $sender      = $p["sender"];
    $recipient   = $p["recipient"];
    $recipientid = $p["recipientid"];
   
    $c =& pfcGlobalConfig::Instance();
    $ct   =& pfcContainer::Instance();
    $u  =& pfcUserConfig::Instance();
   
    $nick = $ct->getNickname($u->nickid);
    $text = trim($param);
//(etc.)

This might seem obvious if you are into programming this system, but it isn't if you are a newbie -- and the problem is this creates a security issue as well (see my "crash" report.)