Kick / Ban reasons

[ljbuesch]

If you try to kick or ban a user and use more than one word in your reason, you only get the first word:

Code: Select all

/kick user You have been naughty

will result in

Code: Select all

user quit (kicked from chan by admin - reason: You

Here is a fix for beta-11

kick.php

Code: Select all

--- beta11    2007-02-15 08:13:34.000000000 -0800
+++ bugfix      2007-07-20 16:13:58.878619000 -0700
@@ -22,6 +22,14 @@
     $reason = isset($params[1]) ? $params[1] : '';
     if ($reason == '') $reason = _pfc("no reason");
 
+    if (count($params) > 2)
+    {
+        for ($x=2;$x<count($params);$x++)
+        {
+            $reason.=" ".$params[$x];
+        }
+    }
+

ban.php

Code: Select all

--- beta11     2007-03-07 11:14:11.000000000 -0800
+++ bugfix       2007-07-20 16:12:15.754543000 -0700
@@ -21,6 +21,15 @@
     $nick   = isset($params[0]) ? $params[0] : '';
     $reason = isset($params[1]) ? $params[1] : '';
     if ($reason == '') $reason = _pfc("no reason");
+
+    if (count($params) > 2)
+    {
+        for ($x=2;$x<count($params);$x++)
+        {
+            $reason.=" ".$params[$x];
+        }
+    }
+

[phpfreechat]

This is not a bug, it's a feature, does this syntaxe work ?

/kick user "You have been naughty"

[Tuxie]

How is this not a bug?

[ljbuesch]

This is not a bug, it's a feature, does this syntaxe work ?

/kick user "You have been naughty"

This syntax worked, although I would still consider it a bug. As a user, I would expect it to work properly w/o having to use quotations around what I am saying. I can see why the implementation requires ""s, but I fail to see why it is considered a feature for these commands.

Thank you for your feedback though, it is much appreciated.

[phpfreechat]

ljbuesch you are right, your solution is more user friendly.
I commited your patch in 1057 revision.

[Agyuku]

mine looks like this:

$reason = isset($params[1]) ? $params[1] : '';
if(count($params) > 2) {
$reason = array_shift($params);
$reason = join(' ',$params);
}

works the same way