max_msg = 0 and multiple rooms

[white_devil]

Hello, first at all congratulations for this excellent software, is really good, and i'm planning myselft to make some code contributions, i just dont understand very well the source structure, so i'm reading it, to see if i can understand it the best.

Sorry about my english, i dont speak it very well.

I have this:

$params["channels"] = array("room 1");
$params["frozen_channels"] = array("room 1", "room 2", "room 3", "room 4", "room 5", "room 6", "room 7", "room 8");
$params["max_channels"] = 5;
$params["max_msg"] = 0;

and i have a list of rooms (from 1 to in my website, but the problem is that when i enter in other room than the default opened room 1, whatever i type isnt displayed, it write it to the file but just doesnt display it, i mean, only the room 1 works fine, the others room i enter just doesnt work.

I tryid changing the max_msg to anything higher than 0 and then it works fine and i can see the history of all the test typing that i made, but if i use max_msg = 0 rooms doesnt work.

any help please? thank you, please let me know if i didnt explain very well

Thanks again

[phpfreechat]

It looks like a bug in pfc. I will look at this problem when I have some time and I will give you feedback here.

[white_devil]

Thank you a lot.

If you want, you can try to explain me which file and/or function should i look for and i can try to fix it and post it, because i really want to understand the script so i can make the code contribution.

Is just my opinion

[phpfreechat]

You are welcomed.
If I remember well max_msg is used in the containers (src/container.class.php or src/containers/file.class.php) so maybe search for it and try to understand the code at this point...

But it should no be easy to understand at beginning. Don't hesitate to ask me about precise piece of code.

[white_devil]

excellent, i'll try it, thank you a lot

[white_devil]

Well, i tryied but i cant found the point, i tried with the read function, and the getMeta but i dont even know very well what i'm looking and i really cant find anything about where it ask for the max_msg to know how many lines should display :S, sorry i just dont understand the structure very well yet, but i keep reading, meanwhile i have another code contribution for something that i saw i'll post it in the right forum.

I'll wait for you to have some time and give me a hand with the bug, because i'm not very sure that i can fix it..

As i said, the messages are being written into the file but not displayed thats why i looked to the read related functions, but well, i better wait

Thank you a lot

[onslo]

Have you tried refreshing the page ?
I have seen similar issues and it seems to relate to the Userchan and DefaultChan arrays that are constructed when the chat page is first opened. A refresh of the page seems to correct the arrays.

see : http://www.phpfreechat.net/forum/viewtopic.php?id=1485

Regards

Onslo

[white_devil]

Hey, thank you for your answer but that didnt work very well (well, it kinda did)

But i saw something, i have 8 channels, (room 1 to if i enter (for example) room 1, room 2 and room 3, i cant write, then if i refresh the work just fine, but only rooms 1, 2 and 3, but when i enter room 4, it doesnt work, and i have to refresh again with the room 4 opened so it will get open automaticly when i refresh and then it works fine...

Any suggestion? because i dont think that asking users to refresh the site before they can chat is a good thing, hehe

[onslo]

Thats right, if you look at the pfc_userchan and pfc_defaultchan arrays in the source of the chat window you will see that they are not fully populated. However, when you refresh the page they do get populated, or in your case just slightly more populated until your refresh again.

I am convinced that this is the issue becuase i am seeing pretty much the same thing and have added some javascript to my chat window to detect whether or not these arrays are correctly populated and if not then alert the user to refresh the page. It's not ideal but it's the only solution that i can come up with at the moment.

Here the code i use ...

place under :

Code: Select all

<?php $chat->printChat(); ?>

Code: Select all

<?php
        #code to check that the defaultchans variable is present in the userchans list
        echo "<script type='text/javascript'>
        for(i = 0; i < pfc_userchan.length; i++){
                if(pfc_defaultchan==pfc_userchan[i]) {
                        var ChansOK=1;
                }
        }
        if(pfc_userchan=='') {
                var ChansOK=1;
        }
        if(ChansOK==1) {
        } else {
                alert("Alert : Multiple Channels - Please Refresh This Page After Loading");
        }
        </script>";
?>

Multiple chat rooms seems to work when the alert is not triggered which suggests to me that the multiple chat facility is dependant upon the population of these arrays.

rgs

Onslo

[white_devil]

nice, that gives me an idea, maybe i could instead of making an alert i could send a function to redefine the array in ajax, so the user doesnt have to make a refresh, i'll give a try, thank you i'll post you a result

[onslo]

I'd be very interested in your results and the code you use to achieve it.

Regards

Onslo

[phpfreechat]

I got it!

Thank youf for the bug report, it's now fixed in SVN.
Here is the patch :

Code: Select all

kerphi@ketchup:~/pfc$ svn diff src/commands/getnewmsg.class.php
Index: src/commands/getnewmsg.class.php
===================================================================
--- src/commands/getnewmsg.class.php    (révision 1039)
+++ src/commands/getnewmsg.class.php    (copie de travail)
@@ -48,16 +48,16 @@
     // create a new lock
     $_SESSION["pfc_lock_readnewmsg_".$c->getId()."_".$clientid] = time();

-
     // read the last from_id value
     $container =& pfcContainer::Instance();
     $from_id_sid = "pfc_from_id_".$c->getId()."_".$clientid."_".$recipientid;
+
     $from_id = 0;
     if (isset($_SESSION[$from_id_sid]))
       $from_id = $_SESSION[$from_id_sid];
     else
     {
-      $from_id = $container->getLastId($recipient)-$c->max_msg;
+      $from_id = $container->getLastId($recipient) - $c->max_msg - 1;
       if ($from_id < 0) $from_id = 0;
     }
     // check if this is the first time you get messages
kerphi@ketchup:~/pfc$ svn commit src/commands/getnewmsg.class.php
Envoi          src/commands/getnewmsg.class.php
Transmission des données .
Révision 1042 propagée.

[white_devil]

Yes!! is working, thank you a lot Stephane (i think that is your name) wow is so cool thank you again!!