[FIX] Nick can be taken over by another user

[softwareNerd]

I am still testing this for a more specific test case, but from what I can tell this is the bug:

If the randomly-generated nick happens to be the same as one already in use, the pop-up asks one to change it. However, if one cancels from there, one gets that nick and the existing user with that nick gets kicked out.

If a nick is not set as a param, then a user who cancels is left with a "blank nick" and pretty inoperable. That's fine.

However, if the nick clashes, or if a default hard-coded nick is passed in as a param to the constructor, the cancel does not work as expected.

Also, what snippet of code can I put in index.php that will quickly test if a nick is already in use and then do a specific action of my choosing, rather than popping up the dialog box.

thx

[softwareNerd]

I just did some tests. Here's a test case that will reproduce the problem:

1) Change the standard index.php file so that $params["nick"] is set to a fixed string, with no random component.

2) Go to chat.

3) Do not shut your browser's session.

4) Open a second browser and go to chat

5) It will pop-up the error dialog asking for nick-change

6) Do not enter a new nick

7) Click the Cancel button

Your second browser session now enters chat with the same nick as the first one. Meanwhile, the first browser session cannot use chat any more.

[phpfreechat]

Right.
I will have a look to this problem.

Thank you for this nice bug report.

[Nemako]

I don't want to write a new topic but I don't know if that's normal that when I arrive on the chat, it ask me a nickname and if I click on cancel, I enter in the chat. Of course I can't write because I have no nickname but nobody see that I am on the chat and I can read message...

Thks

[phpfreechat]

These two bug are now fixed in the pfc source code.
Thanks agin for these bug report

[softwareNerd]

Thank YOU!

I look forward to version v0.8