Chatroom Frozen

[gritty]

We just installed the latest update and were trying out our chatroom again. Things seemed to be going okay, but now all of a sudden no posts are appearing. We tried disconnecting, shutting down, trying a new window, all to no avail. And it's doing this to everyone in our chat (we've been emailing each other wondering if we were experiencing the same thing).

Do you know what's going on?

[lrickyutah]

the same thing happened to me. I had to revert to beta 9. (which still doesn't quite work for me.)

[phpfreechat]

I think the messages index file is just sometime reset to 0 so the new messages doesn't appears in the chat.
This is probably a bug and I think I can fix it with exclusive file locking... I'll keep you informed.

[shacknasty]

We seem to be having this problem too, and the only way I can fix it is by deleting and recreating the data folder

[phpfreechat]

Ok just commited a patch to fix this problem.
Please could you give me some feedback about it ?

Code: Select all

Modified: trunk/src/containers/file.class.php
===================================================================
--- trunk/src/containers/file.class.php 2007-04-01 11:01:46 UTC (rev 1012)
+++ trunk/src/containers/file.class.php 2007-04-01 13:06:42 UTC (rev 1013)
@@ -91,7 +91,7 @@
    }
    else
    {
-      file_put_contents($leaffilename, $leafvalue);
+      flock_put_contents($leaffilename, $leafvalue);
    }

    // store the value in the memory cache
@@ -157,7 +157,7 @@

    if (!file_exists($leaffilename)) return $ret;
    if ($withleafvalue)
-      $ret["value"][] = file_get_contents($leaffilename);
+      $ret["value"][] = flock_get_contents($leaffilename);
    else
      $ret["value"][] = NULL;
    $ret["timestamp"][] = filemtime($leaffilename);

Modified: trunk/src/pfctools.php
===================================================================
--- trunk/src/pfctools.php      2007-04-01 11:01:46 UTC (rev 1012)
+++ trunk/src/pfctools.php      2007-04-01 13:06:42 UTC (rev 1013)
@@ -403,4 +403,40 @@
  }
 }

+/**
+ * Almost the Same as file_get_contents except that it uses flock() to lock the file
+ */
+function flock_get_contents($filename, $mode = "rb")
+{
+  $data = '';
+  if (!file_exists($filename)) return $data;
+
+  $size = filesize($filename);
+  if ($size == 0) return $data;
+
+  $fp   = fopen( $filename, $mode );
+  if( $fp && flock( $fp, LOCK_SH ) )
+  {
+    $data = fread( $fp, $size );
+    flock($fp, LOCK_UN);
+  }
+  fclose( $fp );
+  return $data;
+}
+
+/**
+ * Almost the Same as file_put_contents except that it uses flock() to lock the file
+ */
+function flock_put_contents($filename, $data, $mode = "wb")
+{
+  $fp   = fopen( $filename, $mode );
+  if( $fp && flock( $fp, LOCK_EX ) )
+  {
+    fwrite( $fp, $data );
+    flock($fp, LOCK_UN);
+  }
+  fclose( $fp );
+}
+
+
 ?>

[samp]

I didn´t undestand what we need to do in the trunk/src/pfctools.php file

[pinup57]

in src/pftools.php replace the - lines by the + lines.....

Dirk

[samp]

in src/pftools.php replace the - lines by the + lines.....

Dirk

but there is no - lines in the pftools.php...

so I just need to ad this lines?

[pinup57]

In src/pfctools.php look for the lines identified by a - sign in the code Stéphane posted, and replace them by the lines identified by the + sign (in the same code). The patch basically says: remove line - and add line +.

Dirk

[mslm13]

I'm getting an error after modifying the code. Can any one give me a clue


Parse error: syntax error, unexpected $end in /src/pfctools.php on line 439

[phpfreechat]

mslm13 could you try with this modified function ?

Code: Select all

function flock_put_contents($filename, $data, $mode = "wb")
{
  $fp   = fopen( $filename, $mode );
  if( $fp )
  {
    if ( flock( $fp, LOCK_EX ) )
    {
      fwrite( $fp, $data );
      // flock($fp, LOCK_UN); // will be done by fclose
    }
    fclose( $fp );
  }
}

[mslm13]

It didn't work = I got this error

Parse error: syntax error, unexpected $end in /home/src/pfctools.php on line 442

[srdev]

This code works but the problem stay !

another solution please

he works perfectly on other server.

Is the server dont support anything ?