bug fixes for Drupal integration module

[permutations]

I've posted an update of the Drupal integration module for phpFreeChat on my Web site. It contains numerous bug fixes. This is a new version with two additional fixes:

http://permutations.com/drupal/phpfreechat.php

[permutations]

If you downloaded the 1.1a update from my Web site early this morning, please download it again. Two hours after I uploaded it, I uploaded it again with a small change. The fix to the timeout problem was to change the default timeout in phpFreeChat. I forgot I'd made this change in phpFreeChat itself and not in the module. I changed it so the default is set in the module. The only file changed is phpfreechat.module.

[pcs305]

Thank you for your work permutations!
The "official" drupal module did not work for me I will test your's and give feedback.

[permutations]

I just uploaded a new version:

http://permutations.com/drupal/phpfreechat.php

I backed out setting the default timeout to 35000 in the module. It's not working because the "negative number" error is still happening after clearing the cache (/rehash). The timeout needs to be changed to avoid disconnects, and the easiest way to do this is to change it directly in pfcglobalconfig.class.php. phpFreeChat has an integer check in there, and Drupal's form API doesn't have an integer type. I tried to identify the integer strings and change them and it worked in a test file, but not in the module.

pfcglobalconfig.class.php is in the phpFreeChat src directory (it's not a module file).

1. To change the default timeout, find this variable assignment and change the 20000 to 35000:

Code: Select all

var $timeout = 35000;

2. To get rid of the negative number error, comment out this code in pfcglobalconfig.class.php:

Code: Select all

/*   
    $numerical_positive_params = $this->_params_type["positivenumeric"];
    foreach( $numerical_positive_params as $npp )
    {
      if (!is_int($this->$npp) || $this->$npp < 0)
        $this->errors[] = _pfc("'%s' parameter must be a positive number", $npp);
    }
*/

[permutations]

I created a Drupal theme that is compatible with phpFreeChat that you can download from my Web site:

http://permutations.com/drupal/phpfreechat.php

With Internet Explorer 7, if phpFreeChat is embedded inside a table, the chat scrollbar keeps jumping up so you can't read new messages. You can use the chat only with Firefox, or you can use this theme, which uses CSS rather than tables for positioning. This clean and simple theme comes in blue or purple, and supports all Drupal theme features and many different block areas.

[permutations]

I have a final update of this code on my Web site that also includes an "away" command. Those not using Drupal can still grab the "away" command from the "extras" directory.

http://www.permutations.com/drupal/phpfreechat.php

This package also will be uploaded to Drupal.org in the next day or so - I'm still learning how to use CVS.