new design- rows problem

[zilveer]

hi,
i am still working on the new designing to phpfreechat.
It is going well except one problem I got.


I want the rows have different colors so it looks like:
row1: white
row2: gray
row3: white
row4: gray

and so on...

in file: pfcclient.js,
in function "handleComingRequest: function( cmds )", row 738.

I added the following code in the for-loop:

Code: Select all

      if (mid % 2 == 0)
         line += '<div class=pfc_message1>'
      else
         line += '<div class=pfc_message2>'

it seems to work well when I start the chat but when someone writes a message every row becomes white, like in the picture below:

so the question is how can make the rows become white, gray when writing a message?
http://www.gettot.com/rows.png

/thanks for helping, zilveer

[phpfreechat]

what is the "mid" variable ?

[phpfreechat]

ok I know what is it.
Try this code :

Code: Select all

      if (id % 2 == 0)
          line += '<div class=pfc_message1>'
      else
          line += '<div class=pfc_message2>'

[zilveer]

thanks very much..
I would like to upload the design I have done so people can make even better CSS design. I have added som CSS-class attributes which makes it easier to change the design.

what do you think?I would like to make the design even better but maybe you could implement this code and css design to v1.0 beta7 release?

/thanx, zilveer

[phpfreechat]

You can zip and submit your theme in the contribution section.
Then if it's well coded, I will add it to the official code source.

[zilveer]

ok.. but what about the code i implemented in the pfcclient.js-file? should i add it too the zip-file?

by the way, I should upload it in the contribution-section but should i upload the zip-file wherever i want and then give u a link where you can download it?

/thanx

[phpfreechat]

If the modifications are pertinent, I prefere a patch for this file. Then I will integrate it to the pfc source code.
Otherwise, if it's very specific code, you must add your customization to the customize.js theme file.

[zilveer]

ok.. by the way,
is it possible to write in my code direct to the customize.js theme -file?

[phpfreechat]

yes, as an example, look at demo34

[zilveer]

ok..
i remove my code from pfcclient.js and add it to customize.js but when i do that it writes:

'id' is undefinied.

so how should I do?

edit: i will include a readme textfile where I explain which code I have implemented in the pfcclient.js-file.

[phpfreechat]

what did you put exactly in customize.js ?

[zilveer]

this is the code i pasted in js-file, how should it look alike?

Code: Select all

if (id % 2 == 0)
          line += '<div class=pfc_message1>'
else
          line += '<div class=pfc_message2>'

[phpfreechat]

So, it cannot work.
You look at the demo34 to understand how to overload this function.

If you are not a programmer, just send the zip, I will do the customize.js work for you.

[zilveer]

hi,
sorry for not posting it sooner, i have had a lot of to do in school since i study.

anyway i have uploaded the design and included the pfcclient.js-file and also a readme.txt file where I write what I have done.

link: http://www.gettot.com/default.zip

/thanx, zilveer

[phpfreechat]

Ok thank you zilveer, I will add this task to my todolist.
How do you want to name your theme ? can I name it zilveer ?