Bug fix: when reloading the page, the previously joined chan

[mkoch]

"Bug fix: when reloading the page, the previously joined channels were not joined again as expected."

Is this bug fix commited to SVN? If I reload my page i get the "Missing parameter (/join {channelname})" message. This can be reproduced on demo chat on this site.

[phpfreechat]

Ok, the bug was not completly fixed, now it's ok with this patch (is on the subversion):

Code: Select all

Modified: trunk/themes/default/templates/pfcclient.js.tpl.php
===================================================================
--- trunk/themes/default/templates/pfcclient.js.tpl.php 2006-06-15 11:50:12 UTC (rev 583)
+++ trunk/themes/default/templates/pfcclient.js.tpl.php 2006-06-15 11:56:43 UTC (rev 584)
@@ -302,11 +302,13 @@
            echo "this.sendRequest('".$cmd."', '".addslashes($ch)."');n";
          }
        // the last joined channel must be the last entry in the parameter list
-        for($i=0; $i<count($u->channels); $i++)
+        $i = 0;
+        foreach($u->channels as $ch)
        {
-          $ch = $u->channels[$i]["name"];
+          $ch = $ch["name"];
          $cmd = $i < count($u->channels)-1 ? "/join2" : "/join";
          echo "this.sendRequest('".$cmd."', '".addslashes($ch)."');n";
+          $i++;
        }
        foreach($u->privmsg as $pv)
          echo "this.sendRequest('/privmsg', '".addslashes($pv["name"])."');n";

[mkoch]

I see this now works in demo.

I updated my SVN but still not works for me.

It re-joins the room, but it is blank I can no longer type anything in it.