noflood problem

[permutations]

People are getting kicked out of the chat with a "noflood" message when they are not flooding. This seems to be new with v1.2. What is causing this, and is there a workaround?

Thanks.

[Jamesiv4]

I had the same problem, so I edited src/proxies/noflood.class.php and basically removed all the code. Be sure to save a copy of the original.

Code: Select all

<?php
/**
 * noflood.class.php
 *
 * Copyright © 2006 Stephane Gully <stephane.gully@gmail.com>
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library; if not, write to the
 * Free Software Foundation, 51 Franklin St, Fifth Floor,
 * Boston, MA  02110-1301  USA
 */
require_once dirname(__FILE__)."/../pfci18n.class.php";
require_once dirname(__FILE__)."/../pfcuserconfig.class.php";
require_once dirname(__FILE__)."/../pfcproxycommand.class.php";
require_once dirname(__FILE__)."/../../lib/utf8/utf8_strlen.php";

?>

[permutations]

Thanks. I discovered there's actually a parameter to disable this:

Code: Select all

$params['skip_proxies'] = array('noflood');

[Jamesiv4]

yeah... I tried the parameter, but it didn't work for me. Thanks, though.

[phpfreechat]

Maybe you need to rehash the chat ?
More info about the noflood proxy can be found here: http://www.phpfreechat.net/proxies#noflood

[Jamesiv4]

Hi Stephane,

Yes... I rehashed and rehashed, but no joy with the skip_proxies parameter. It seemed to only happen with users that were using Internet Explorer - Firefox users did not experience the problem.

Thanks.

[permutations]

The parameter works fine for me. Perhaps there is an error in your syntax.

[JediBR]

I have the same problem here.

Version 1.2

To reproduce the bug do the following:
1. Flood a 1 to 10 count to be kicked
2. Rejoin the channel
3. Say 1 message.
4. Say another message.
5. Last message won't be sent. You'll be kicked.

I've read the code. Seems ok for me... I even reidented it to be more comfortable to me... No success... Is there any fix? It's realy annoying, and I can't remove the protection because it will be an open chat for a large public, and we expect there will be disturbing flooders... :/

[ ############################# PROBLEM SOLVED ############################# ]

This patch also fixes the noflood bug (i'm not 100% sure, but it's certainly better)
http://www.phpfreechat.net/forum/viewto ... 944#p10944

[nibbles]

I have solved the problem replacing $flood_nbmsg++; with $flood_nbmsg+=0.5; in this section of src/proxies/noflood.class.php

if ($floodtime - $lastfloodtime <= $c->proxies_cfg[$this->proxyname]["delay"])
{
// update the number of posted message indicator
$flood_nbmsg+=0.5;
// update the number of posted characteres indicator
$flood_nbchar += utf8_strlen($param);
}