parameter changes reported as \"negative values\"

[permutations]

I'm using phpFreeChat inside Drupal, but I don't think Drupal is causing this problem.

When I make a parameter change to a numerical parameter (e.g. changing the timeout to 31000), phpFreeChat reports I've passed a negative value. I know I have not because I looked at the params array being passed in.

Any time I ever change a numeric value, I get this error from phpFreeChat. Anyone know what causes it?

[phpfreechat]

The code in pfc that tests the positive numerics is this one :

Code: Select all

    $numerical_positive_params = $this->_params_type["positivenumeric"];
    foreach( $numerical_positive_params as $npp )
    {
      if (!is_int($this->$npp) || $this->$npp < 0)
        $this->errors[] = _pfc("'%s' parameter must be a positive number", $npp);
    }

I think your 31000 number is not an integer, it's probably a string ("31000"). You could try to patch the drupal code to cast the value to a numeric value.
Or you can patch the phpfreechat code to remove this code (but I cannot guarantee that it will work nice if the value is a string).

[OldWolf]

Or easier still:
settype($variable_goes_here, "integer");

[permutations]

Thanks. I'm sure this is it.

Calling settype() is easy, but identifying which of the dozens of parameters I need to call it for is tedious. I'm trying to think of an easy way to do this without modifying pfc. It would be easiest to modify pfc, but inelegant.

[permutations]

Got it:

Code: Select all

  foreach($params as $key => $value)
  {
    if (!is_array($value)) {
     $integer_string = (preg_match("/[0-9]/", $value) && !preg_match("/[^0-9]/", $value)) ? true : false;
     if ($integer_string) {
       settype($value, "int");
     }
   }
  }

It works! No more error message.

[permutations]

Unfortunately, this worked in the test file but not in the module. I just commented out the check in phpglobalconfig.class.php.

[permutations]

I was able to fix this with simpler code in a different place in the Drupal module:

Code: Select all

if (is_numeric($value))
    $params[$setting] = (int) $value;