[FIX] Can\'t hide smileys

[Yusuke]

$params = array();
$params["nick"] = "guest".rand(1,1000);
$params["serverid"] = md5(__FILE__);
$params["language"] = "fr_FR";
$params["btn_sh_whosonline"] = false;
$params["showsmileys"] = false;
$params["btn_sh_smileys"] = false;


I placed those lines, and the smileys are still there
Zapped my cookies, even reboot, still there.
The button for who's online isn't showing though, but both the smiley button AND the smileys windows are there.

What did i do wrong?
How can i do to have phpfreechat not showing the smiley box?
I placed onload="pfc.showHideSmileys()" in the body tag, but that's not really clean

Yusuke

[phpfreechat]

It's now fixed in the subversion repository.
Thank you for the bug report
It will be ok in the next release but if you can't wait, here is the patch:

Code: Select all

Modified: trunk/themes/default/templates/pfcclient.js.tpl.php
==============================================================================
--- trunk/themes/default/templates/pfcclient.js.tpl.php (original)
+++ trunk/themes/default/templates/pfcclient.js.tpl.php Sun Apr  2 22:33:57 2006
@@ -899,19 +899,24 @@
  {
    var content = $('<?php echo $prefix; ?>smileys');
    var btn = $('<?php echo $prefix; ?>showHideSmileysbtn');
-    if (!btn) return;
    if (this.showsmileys)
    {
-      btn.src = "<?php echo $c->getFileUrlFromTheme('images/smiley-on.gif'); ?>";
-      btn.alt = this.i18n.hidesmiley;
-      btn.title = btn.alt;
+      if (btn)
+      {
+        btn.src = "<?php echo $c->getFileUrlFromTheme('images/smiley-on.gif'); ?>";
+        btn.alt = this.i18n.hidesmiley;
+        btn.title = btn.alt;
+      }
      content.style.display = 'block';
    }
    else
    {
-      btn.src = "<?php echo $c->getFileUrlFromTheme('images/smiley-off.gif'); ?>";
-      btn.alt = this.i18n.showsmiley;
-      btn.title = btn.alt;
+      if (btn)
+      {
+        btn.src = "<?php echo $c->getFileUrlFromTheme('images/smiley-off.gif'); ?>";
+        btn.alt = this.i18n.showsmiley;
+        btn.title = btn.alt;
+      }
      content.style.display = 'none';
    }
    this.refresh_Chat();
@@ -977,7 +982,6 @@
      style['height'] = '100%';
      Element.setStyle(smileysdiv, style);
    }
-
    if (this.showsmileys)
    {
      style['height'] = '';

regards,

[Yusuke]

looks like it works

nice and quick, chapeau

[Yusuke]

while i'm at it, anyway to kick/ban ppl yet?
or is it still to be implemented?