When closing private chat...

[chat27]

When closing a private chat window, v.1x beta asks if you're sure you want to leave the room. Now that's gonna freak out novice users

[phpfreechat]

What do you suggest ? remove the alert ?

[chat27]

Well, since it asks you the same question whether you're closing a channel window or private chat window, maybe it could just ask "Are you sure you want to close this tab?", as I do believe a confirmation dialogue is needed for people like me that are forever clicking the wrong close button! lol

[phpfreechat]

Your suggestion does make sense. I will change this label when I got time.

[phpfreechat]

I made the change.
Here is the patch applied in 1044 revision

Code: Select all

kerphi@ketchup:~/pfc$ svn diff src/phpfreechat.class.php data/public/js/pfcgui.js
Index: src/phpfreechat.class.php
===================================================================
--- src/phpfreechat.class.php   (révision 1039)
+++ src/phpfreechat.class.php   (copie de travail)
@@ -411,6 +411,7 @@

     $labels_to_load =
       array( "Do you really want to leave this room ?", // _pfc
+             "Are you sure you want to close this tab ?", // _pfc
              "Hide nickname marker", // _pfc
              "Show nickname marker", // _pfc
              "Hide dates and hours", // _pfc
Index: data/public/js/pfcgui.js
===================================================================
--- data/public/js/pfcgui.js    (révision 1039)
+++ data/public/js/pfcgui.js    (copie de travail)
@@ -254,7 +254,9 @@
       a2.pfc_tabname = name;
       a2.pfc_tabtype = type;
       a2.onclick = function(){
-        var res = confirm(pfc.res.getLabel('Do you really want to leave this room ?'));
+        var msg = (type == 'pv' ? 'Are you sure you want to close this tab ?' :
+                                  'Do you really want to leave this room ?');
+        var res = confirm(pfc.res.getLabel(msg));
         if (res == true)
           pfc.sendRequest('/leave',this.pfc_tabid);
         return false;