Disconnect in 1-2 minutes

[a3093]

We having problem, with the timeout. This is a problem, user's cannot type in the chatroom, because they are idle in the long period of time (ex 1-2 minutes or so)

POST:
pfc_ajax=1&f=handleRequest&cmd=%2Fconnect%20da326533cb9ff71947c477fc35164d24%202fae3120275de71ee16be96f2b6de29b%20
RESPONSE:
pfc.handleResponse('nick', 'connected', 'myuser');
pfc.handleResponse('join', 'ok', Array('2fae3120275de71ee16be96f2b6de29b','mychat'));
pfc.handleResponse('connect', 'ok', Array(''));
pfc.handleResponse('update', 'ok', '');

POST:
pfc_ajax=1&f=handleRequest&cmd=%2Fupdate%20da326533cb9ff71947c477fc35164d24%202fae3120275de71ee16be96f2b6de29b%20 [641 ms]
RESPONSE:
pfc.handleResponse('whois2', 'ok', {"ip":"80.00.00.5","isadmin":"1","floodtime":"1209634661","flood_nbmsg":"","flood_nbchar":"","nick":"myuser","nickid":"d1a1cf2192e0ce637f2f16d4ee491d1f"});
pfc.handleResponse('update', 'ok', '');

POST:
pfc_ajax=1&f=handleRequest&cmd=%2Fupdate%20da326533cb9ff71947c477fc35164d24%202fae3120275de71ee16be96f2b6de29b%20 [703 ms]
RESPONSE:
pfc.handleResponse('update', 'ok', '');
...
...
[1 min - 2 min]
...
...
POST:
pfc_ajax=1&f=handleRequest&cmd=%2Fupdate%20da326533cb9ff71947c477fc35164d24%202fae3120275de71ee16be96f2b6de29b%20 [894 ms]
RESPONSE:
pfc.handleResponse('update', 'ok', '');

POST:
pfc_ajax=1&f=handleRequest&cmd=%2Fupdate%20da326533cb9ff71947c477fc35164d24%202fae3120275de71ee16be96f2b6de29b%20 [1232 ms]
RESPONSE:
pfc.setError('Debes estar conectado para enviar un mensaje', Array());

[permutations]

I have the same problem with timing out. But what are those post/response values you're sending?

When the user is disconnected, the "Connect" button is still enabled. Sometimes typing /quit and /connect will get things working. Other times, that won't restore all the settings (like typing color) and you have to reload the chatbox completely.

Is the developer aware of this bug? Does anyone have a fix?

[permutations]

I think this message may describe the cause of the problem and the fix:

http://www.phpfreechat.net/forum/viewtopic.php?pid=9711

[a3093]

I have the same problem with timing out. But what are those post/response values you're sending?

It is obtained from the extension of firefox FireBug. It is very good.

[a3093]

My problem is:

http://sourceforge.net/tracker/index.ph ... tid=809601

and there isn't solution yet

[phpfreechat]

a3093, could you try to change the timeout value of your chat, to this :
$params["timeout"] = 35000;

(dont forget to rehash the chat)

[a3093]

Hello Kerphi,

I found the bug, but not how to solve.

The file: dataprivatechats_d7c4......f57afchannelid-to-nickidSERVER74808bec........565

is unable to update the date.



In the file: pfccontainer.class.php in the function: removeObsoleteNick there is this line:

if (time() > ($timestamp+$timeout/1000) && $nickid) // user will be disconnected after 'timeout' secondes of inactivity

And its variables are:

time: 1210015962 timestamp: 1210015931 + timeout: 60000 /1000
time: 1210015967 timestamp: 1210015931 + timeout: 60000 /1000
time: 1210015972 timestamp: 1210015931 + timeout: 60000 /1000
time: 1210015977 timestamp: 1210015931 + timeout: 60000 /1000
time: 1210015982 timestamp: 1210015931 + timeout: 60000 /1000
time: 1210015987 timestamp: 1210015931 + timeout: 60000 /1000
time: 1210015992 timestamp: 1210015931 + timeout: 60000 /1000

the timestamp no update!

[a3093]

and I found the problem.... I think.

FILE: src/containers/file.class.php

Function: setMeta

Original Code:

Code: Select all

 if ($leafvalue == NULL)
    {
     file_put_contents($leaffilename, '', LOCK_EX);
    }
    else
    {
     file_put_contents($leaffilename, $leafvalue, LOCK_EX);
    }

New Code:

Code: Select all

 if ($leafvalue == NULL)
{

    // BAD
    //file_put_contents($leaffilename, '', LOCK_EX);

    // CORRECT
    $file=fopen($leaffilename,"w");
    fwrite($file,time()." rn");
    fclose($file);
}
else
{
    //BAD
    //file_put_contents($leaffilename, $leafvalue, LOCK_EX);

    // CORRECT
    $file=fopen($leaffilename,"w");
    fwrite($file,$leafvalue);
    fclose($file);
}

parameters: (approximately)
$params["refresh_delay"]=5000;
$params["timeout"]=600000;

[phpfreechat]

a3093, the LOCK_EX flag is important. It allows concurrent access on the same file.
If you remove this flag, the chat internal files could be corrupted.

Moreover, I don't understand the logic of your patch. Functionally it does exactly the same as before.

[a3093]

The problem is that the instruction

file_put_contents($leaffilename, '', LOCK_EX);


do not write anything in the file, does not modify it and possibly that's why so the server does not update the date. Possibly be solved by simply write anything in the file. For example:

file_put_contents ($ leaffilename, time (), LOCK_EX);

[cls]

Hmm, I don't know, if

Code: Select all

file_put_contents($leaffilename, '', LOCK_EX);

is needed to create the file at this point.

Perhaps it helps, if you add

Code: Select all

touch($leaffilename);

after this line.

[phpfreechat]

Ok, so according to cls's and your idea, could you try this patch ?

Code: Select all

Index: containers/file.class.php
===================================================================
--- containers/file.class.php   (révision 1238)
+++ containers/file.class.php   (copie de travail)
@@ -99,7 +99,7 @@
     $leafexists = file_exists($leaffilename);
     if ($leafvalue == NULL)
     {
-       file_put_contents($leaffilename, '', LOCK_EX);
+      touch($leaffilename);
     }
     else
     {

Please keep me informed if it fixes the problem and I'll commit the patch on the official source code.

[a3093]

It is OK

[kswift]

It still gives me the same errors here (you need to be logged in...). Though they seem to come less frequent? Not sure, still running the patch.

[Brazo]

thank you

this post solves an identical problem on my server !!!

*thumbs up*