pfc.insert_text error

[onslo]

Clicking on a nick in the chat interface in Firefox inserts the nick into the input text box, but this does not work in Internet Explorer or Opera.
Internet Explorer shows a javascript error...

Error : 'undefined' is null or not an object

Any clues as to how to fix ?

I am running 1.0-beta9 at the moment, but your demo of 1.0-beta10 also exhibits the same problem.

rgs

onslo

[onslo]

Anyone replicated this yet or any ideas on how to resolve it ?

Regards

Onslo

[phpfreechat]

Thank you for the bug report, I will add it to my todo list.

[phpfreechat]

Thank you for your bug report, I fixed the bug in 1045 revision.

Here is the patch I applied :

Code: Select all

kerphi@ketchup:~/pfc$ svn diff data/public/js/pfcclient.js
Index: data/public/js/pfcclient.js
===================================================================
--- data/public/js/pfcclient.js (révision 1040)
+++ data/public/js/pfcclient.js (copie de travail)
@@ -1550,11 +1550,10 @@
     if (document.selection && document.selection.createRange)
     {
       msgfield.focus();
-      sel = document.selection.createRange();
-      var text = sel.text;
+      pfcp.sel = document.selection.createRange();
+      var text = pfcp.sel.text;
       if (text == "" && promptifselempty)
       {
-        pfcp.sel = document.selection.createRange();
         pfcp.prompt(this.res.getLabel('Enter the text to format'), '');
         pfcp.focus();
       }
@@ -1594,7 +1593,6 @@
     var promptifselempty = pfcp.promptifselempty;
     var msgfield         = pfcp.msgfield;
     var sel              = pfcp.sel;
-
     // IE support
     if (document.selection && document.selection.createRange)
     {