Smiley alt and title tags are escaped html

[King Moonraiser]

The alt and title tags are escaped html. For example, in the phpbb2 theme, the ":-&" smiley shows up as ":-&" when you hover over the smiley. I was able to patch the pfcgui.js file, but I'm sure I didn't do it in the most efficient manner possible:

Code: Select all

  loadSmileyBox: function()
  {
    var container = $('pfc_smileys');
    var smileys = pfc.res.getSmileyReverseHash();//getSmileyHash();
    var sl = smileys.keys();
    for(var i = 0; i < sl.length; i++)
    {
      s_url    = sl[i];
      s_symbol = smileys[sl[i]];
      s_symbol = s_symbol.unescapeHTML();
     
      var img = document.createElement('img');
      img.setAttribute('src', s_url);
      img.setAttribute('alt', s_symbol);
      img.setAttribute('title', s_symbol);
      img.s_symbol = s_symbol;
      img.onclick = function(){ pfc.insertSmiley(this.s_symbol); }
      container.appendChild(img);
      container.appendChild(document.createTextNode(' ')); // so smileys will wrap fine if lot of smiles in theme.

BTW, the "oops" tag is "<oops>". Shouldn't it be ":oops:" to be consistent with the rest?

[King Moonraiser]

I have IE users who have problems with escaped smilies. (I'm using the phpbb2 theme.)

For example, the whistling smilie should be :-/" but it gets sent as :-/"

For some reason, the IE users are escaping their smilie code. BTW, this is a different issue than the code fix I posted above. That just fixes the alt img tags for all browsers.

[Luxian]

I have the same problem with a smile theme created by me, after Yahoo! Messenger Smiles.
I have problems with the following codes:

Code: Select all

:-"
:">
m/

When I click on the smiles, I get the following codes:

Code: Select all

:-"
:">
\M/

phpFreeChat: v1.2
Browsers:
- Firefox: 3.0.4
- Opera 9.62
- Crome 0.3.154.9
- IE 7
php: 5.2.5
magic_quotes_gpc: Off


Any suggestions?

[phpfreechat]

This bug has been fixed in revision 1255 (available in next 1.3 version)

[Luxian]

I've downloaded the revision 1257 from SVN. No changes in test results. Same smiles, same results like before.

I don't remember how they appear in chat. Maybe that is the difference, but the bug was not totally fixed.

The enviroment used for testing is the same like above

Any ideas?