• Forum
  • Doc
  • Screenshots
  • Download
  • Donate
  • Contributors
  • Contact
  • Follow @phpfreechat
  • DEMO
  • Board index ‹ Version 1.x branch ‹ Feature Requests (v1.x)
  • Change font size
  • FAQ
  • Register
  • Login

change of nick message

This forum is now locked as we will no longer be developing the v1.x branch

Moderators: OldWolf, re*s.t.a.r.s.*2

Topic locked
10 posts • Page 1 of 1

Postby cdn » Sat Jul 26, 2008 8:25 am

this is a little pedantic, but the message

bert changes his/her nickname to fred

could be be changed to say:-

bert changes nickname to fred

or

bert changes nick to fred

Yup i know, details, details
cdn
Member
 
Posts: 21
Joined: Wed Jul 23, 2008 11:53 am
Top

Postby cdn » Sat Jul 26, 2008 8:34 am

maybe a setting in the param block along the lines of printf et al

sparams['nickChangeMessage'] = string %1 to %2

where %1 is the from nick and %2 is the to nick

Example:

sparams['nickChangeMessage'] = "Nick Change %1 to %2"

Just a thought
cdn
Member
 
Posts: 21
Joined: Wed Jul 23, 2008 11:53 am
Top

Postby phpfreechat » Sat Jul 26, 2008 10:41 am

This change should be done in the translations files. (i18n directory)
I commited the change in the 1242 revision.
phpfreechat
Site Admin
 
Posts: 2657
Joined: Tue Feb 07, 2006 3:35 pm
Location: France
Top

Postby cdn » Sat Jul 26, 2008 10:59 am

so the text is hard coded in the language directory. Implied by anii8n call

My point is that the message should be flexible and modifiable by an application programmer.

Changing the language scripts is a no no, the message should be parsed before being thrown at any language translation.

Admittedly this causes problems with different language grammars.

deciding where to place a name inside a sentence changes from language to language. However, the use of place holders for names eradicates this difficulty.
cdn
Member
 
Posts: 21
Joined: Wed Jul 23, 2008 11:53 am
Top

Postby cdn » Sat Jul 26, 2008 11:05 am

on reflection, maybe the language should be translated first and then the place holders are inserted after exit from the translation
cdn
Member
 
Posts: 21
Joined: Wed Jul 23, 2008 11:53 am
Top

Postby cdn » Sat Jul 26, 2008 11:07 am

maybe a pseudo printf after exit from the language translation ?
cdn
Member
 
Posts: 21
Joined: Wed Jul 23, 2008 11:53 am
Top

Postby phpfreechat » Sat Jul 26, 2008 11:09 am

Currently phpfreechat is translated in 39 languages. I agree that these translations could be "subjectives" but until today nobody complains about "wrong" translation. I also agree that it would be better if the translation strings could be customized using the $params array.

If you are motivated, please implement this feature, i'm opened to integrate a such patch in the source code.
phpfreechat
Site Admin
 
Posts: 2657
Joined: Tue Feb 07, 2006 3:35 pm
Location: France
Top

Postby cdn » Sat Jul 26, 2008 11:24 am

I note that you use sourceforge, i will pull down the CVS for current development. I play with sourceforge myself.

Not having developer download/upload, if i play can i send you CVS patches ?

Working on linux and cervisia - the windows laptop is just testing and play time <g>

Mind you i run test systems locally on Apache etc. and have one on the ISPs box
cdn
Member
 
Posts: 21
Joined: Wed Jul 23, 2008 11:53 am
Top

Postby phpfreechat » Sat Jul 26, 2008 11:32 am

We use SVN but it's very similar to CVS. Your patches will be welcome.
phpfreechat
Site Admin
 
Posts: 2657
Joined: Tue Feb 07, 2006 3:35 pm
Location: France
Top

Postby cdn » Sat Jul 26, 2008 11:47 am

Stephane, do me a small favour.

try

http://christchurchlye.org.uk/devsystem


right hand side option -chatroom

then click on start chat in window.

ignore the alert box its a diagnostic.

I see a flicker before the object is displayed, almost like a default display of the object - any ideas ?
cdn
Member
 
Posts: 21
Joined: Wed Jul 23, 2008 11:53 am
Top


Topic locked
10 posts • Page 1 of 1

Return to Feature Requests (v1.x)

Who is online

Users browsing this forum: No registered users and 2 guests

  • Board index
  • The team • Delete all board cookies • All times are UTC + 1 hour
Powered by phpBB® Forum Software © phpBB Group
Sign in
Wrong credentials
Sign up I forgot my password
.
jeu-gratuit.net | more partners
Fork me on GitHub